-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps][Connectors] Highlight step as optional in connector creation form #191918
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
@mdefazio @MichaelMarcialis @kyrspl I was looking for pattern guidance on this and found this issue #195048. All fields inside Can you give me a recommendation here for consistency's sake? |
Rather than adding "(optional)" text, my first instinct here would be to change the "Add comment in case" header to a togglable element, like an |
It's a good idea @MichaelMarcialis and makes a lot of sense in this flow. @adcoelho as agreed, please substitute the header to an EuiSwitch. Should look like this (same for the edit flow): Feel free to merge this as an interim version and add the toggle version later on. cc: @cnasikas |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @adcoelho |
Summary
I have added the
(optional)
text to step 4 of theWebhook - Case management
creation form.Before
After